[webkit-reviews] review granted: [Bug 210710] REGRESSION (r244091): Leak of TaskStateChangedCallbackType due to missing -dealloc : [Attachment 396887] Patch v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 210710: REGRESSION (r244091): Leak of TaskStateChangedCallbackType due to
missing -dealloc
https://bugs.webkit.org/show_bug.cgi?id=210710

Attachment 396887: Patch v1

https://bugs.webkit.org/attachment.cgi?id=396887&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 396887
  --> https://bugs.webkit.org/attachment.cgi?id=396887
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=396887&action=review

> Source/WebKit/Shared/Cocoa/ProcessTaskStateObserver.mm:49
> +    _taskStateChangedCallback = nil;

Seems unnecessary to set things to nil in dealloc.