[webkit-reviews] review denied: [Bug 210636] [GTK] Crash in cairo_surface_mark_dirty_rectangle() in accelerated compositing mode : [Attachment 396768] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has denied  review:
Bug 210636: [GTK] Crash in cairo_surface_mark_dirty_rectangle() in accelerated
compositing mode
https://bugs.webkit.org/show_bug.cgi?id=210636

Attachment 396768: Patch

https://bugs.webkit.org/attachment.cgi?id=396768&action=review




--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 396768
  --> https://bugs.webkit.org/attachment.cgi?id=396768
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396768&action=review

> Source/WebKit/ChangeLog:1
> +2020-04-17  Michael Catanzaro  <mcatanzaro at gnome.org>

You should credit John or even Uli, I think.

> Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp:373
> +    cairo_surface_flush(m_surface.get());
> +

This is not needed in Wayland. In this case we are writing the pixel data
directly, so there aren't snapshots, and the surface is never modified after
the paint, like in X11.