[webkit-reviews] review granted: [Bug 210700] Fix WebUserContentControllerProxy vs ContentWorld lifetime : [Attachment 396868] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 210700: Fix WebUserContentControllerProxy vs ContentWorld lifetime
https://bugs.webkit.org/show_bug.cgi?id=210700

Attachment 396868: Patch

https://bugs.webkit.org/attachment.cgi?id=396868&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 396868
  --> https://bugs.webkit.org/attachment.cgi?id=396868
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396868&action=review

> Source/WebKit/UIProcess/API/APIContentWorld.cpp:38
> +    static HashMap<WTF::String, ContentWorld*>* sharedMap = new
HashMap<WTF::String, ContentWorld*>;

NeverDestroyed<HashMap<...>> to be consistent with below.

> Source/WebKit/UIProcess/API/APIContentWorld.h:61
> +    HashSet<WebKit::WebUserContentControllerProxy*>
m_associatedContentControllerProxies;

Could we use WeakPtr here instead of storing raw pointers?