[webkit-reviews] review requested: [Bug 210672] Web Inspector: removing a `WI.TreeElement` in a `WI.NavigationSidebar` doesn't check if the `WI.TreeOutline` still matches the current filter : [Attachment 396820] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 17 17:52:22 PDT 2020


Devin Rousso <drousso at apple.com> has asked  for review:
Bug 210672: Web Inspector: removing a `WI.TreeElement` in a
`WI.NavigationSidebar` doesn't check if the `WI.TreeOutline` still matches the
current filter
https://bugs.webkit.org/show_bug.cgi?id=210672

Attachment 396820: Patch

https://bugs.webkit.org/attachment.cgi?id=396820&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Created attachment 396820

  --> https://bugs.webkit.org/attachment.cgi?id=396820&action=review

Patch

well one optimization would be to only look inside the `WI.TreeOutline` that
actually changed :P


More information about the webkit-reviews mailing list