[webkit-reviews] review granted: [Bug 210672] Web Inspector: removing a `WI.TreeElement` in a `WI.NavigationSidebar` doesn't check if the `WI.TreeOutline` still matches the current filter : [Attachment 396800] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 210672: Web Inspector: removing a `WI.TreeElement` in a
`WI.NavigationSidebar` doesn't check if the `WI.TreeOutline` still matches the
current filter
https://bugs.webkit.org/show_bug.cgi?id=210672

Attachment 396800: Patch

https://bugs.webkit.org/attachment.cgi?id=396800&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 396800
  --> https://bugs.webkit.org/attachment.cgi?id=396800
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396800&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:634
> +    _handleTreeElementRemoved(event)
> +    {
> +	   this._checkForEmptyFilterResults();

I wonder how much time is spent in `_checkForEmptyFilterResults` during bulk
modifications (adds or removes). That could easily be made more efficient if
needed.