[webkit-reviews] review requested: [Bug 210668] Reduce parameter list of the FrameLoadRequest constructor : [Attachment 396792] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 17 14:32:16 PDT 2020
Rob Buis <rbuis at igalia.com> has asked for review:
Bug 210668: Reduce parameter list of the FrameLoadRequest constructor
https://bugs.webkit.org/show_bug.cgi?id=210668
Attachment 396792: Patch
https://bugs.webkit.org/attachment.cgi?id=396792&action=review
--- Comment #2 from Rob Buis <rbuis at igalia.com> ---
Comment on attachment 396792
--> https://bugs.webkit.org/attachment.cgi?id=396792
Patch
Note that the parameter list can be reduced more or less, this is a somewhat
arbitrary length. It is also possible that some of the remaining parameters are
better candidates for setters.
More information about the webkit-reviews
mailing list