[webkit-reviews] review granted: [Bug 210658] REGRESSION (r234105): [iOS] WKColorButton leaks a UIColor : [Attachment 396770] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 17 10:15:28 PDT 2020

Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 210658: REGRESSION (r234105): [iOS] WKColorButton leaks a UIColor

Attachment 396770: Patch v1


--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 396770
  --> https://bugs.webkit.org/attachment.cgi?id=396770
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=396770&action=review

> Source/WebCore/page/Chrome.cpp:428
>      return nullptr;
> -#endif
> +#else
>      notifyPopupOpeningObservers();
>      return m_client.createColorChooser(client, initialColor);
> +#endif

We need UNUSED_PARAM here.

I also think the "always-null color chooser" design strategy is a little messy,
but that goes beyond this function

More information about the webkit-reviews mailing list