[webkit-reviews] review granted: [Bug 210642] [GTK] Update for GdkKeymap API changes : [Attachment 396747] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Claudio Saavedra
<csaavedra at igalia.com>'s request for review:
Bug 210642: [GTK] Update for GdkKeymap API changes
https://bugs.webkit.org/show_bug.cgi?id=210642

Attachment 396747: Patch

https://bugs.webkit.org/attachment.cgi?id=396747&action=review




--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 396747
  --> https://bugs.webkit.org/attachment.cgi?id=396747
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396747&action=review

> Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp:1345
> +    return
gdk_keymap_get_caps_lock_state(gdk_keymap_get_for_display(gdk_display_get_defau
lt()));

Ah, too bad we are not saving the “GdkEventKey“ as part of the
“PlatformKeyboardEvent” struct; if that was the case we could use

 
gdk_keymap_get_for_display(gdk_window_get_display(gdk_event_get_window(event)))

to make this more precise. Anyhoo, just throwing ideas around, I think
the proposed change is fine as-is because the _get_default() was being
used before anyway.

> Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:307
> +    GdkDisplay* display = gdk_window_get_display(pressEvent->key.window);

Please change this to use “gdk_event_get_window(pressEvent)” before
landing instead of accessing “pressEvent->key.window” directly.