[webkit-reviews] review granted: [Bug 210606] Stop including style rules related to media controls in the UA style sheet when Modern Media Controls are enabled : [Attachment 396764] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 210606: Stop including style rules related to media controls in the UA
style sheet when Modern Media Controls are enabled
https://bugs.webkit.org/show_bug.cgi?id=210606

Attachment 396764: Patch

https://bugs.webkit.org/attachment.cgi?id=396764&action=review




--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 396764
  --> https://bugs.webkit.org/attachment.cgi?id=396764
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396764&action=review

This patch looks good. A better patch would add tests for the UA stylesheet
changes and the runtime enabled branch.

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:25
>  body:-webkit-full-page-media {

The optimal solution would remove this because it duplicates the style in
html.css now. If it cannot be removed, why?