[webkit-reviews] review granted: [Bug 210603] [GTK][X11] REGRESSION(r259944): Wrong position of select popup menu in X11 : [Attachment 396761] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 17 08:09:38 PDT 2020
Michael Catanzaro <mcatanzaro at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 210603: [GTK][X11] REGRESSION(r259944): Wrong position of select popup menu
in X11
https://bugs.webkit.org/show_bug.cgi?id=210603
Attachment 396761: Patch
https://bugs.webkit.org/attachment.cgi?id=396761&action=review
--- Comment #5 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 396761
--> https://bugs.webkit.org/attachment.cgi?id=396761
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=396761&action=review
> Source/WebKit/ChangeLog:9
> + gdk_window_move_to_rect expects the given rectangle in coordinates
relative to the top-left corner of the window
> + that the popup window is transient for. We were using screen
coordinates.
Yup.
More information about the webkit-reviews
mailing list