[webkit-reviews] review granted: [Bug 207330] Fix code origin when lowering offlineasm instructions on MIPS/ARM64E : [Attachment 396753] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 17 07:32:35 PDT 2020
Mark Lam <mark.lam at apple.com> has granted Angelos Oikonomopoulos
<angelos at igalia.com>'s request for review:
Bug 207330: Fix code origin when lowering offlineasm instructions on
MIPS/ARM64E
https://bugs.webkit.org/show_bug.cgi?id=207330
Attachment 396753: Patch
https://bugs.webkit.org/attachment.cgi?id=396753&action=review
--- Comment #10 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 396753
--> https://bugs.webkit.org/attachment.cgi?id=396753
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=396753&action=review
r=me with fixes.
> Source/JavaScriptCore/offlineasm/arm64e.rb:48
> + tag = riscLowerOperandToRegister(node, newList,
postInstructions,
> + 1, "p", false)
Please fix alignment or preferably, put on 1 line.
> Source/JavaScriptCore/offlineasm/risc.rb:449
> + newOperands << riscLowerOperandToRegister(insn, preList, postList,
> + index, suffix,
> + index == insn.operands.size -
1)
This alignment is off. Please fix the alignment, or preferably, just put this
on 1 line.
> Source/JavaScriptCore/offlineasm/risc.rb:458
> + operand = riscLowerOperandToRegister(self, preList, postList,
> + operandIndex, suffix,
> + needStore)
This alignment is off. Please fix the alignment, or preferably, just put this
on 1 line.
More information about the webkit-reviews
mailing list