[webkit-reviews] review granted: [Bug 210620] Add a new 'limitNavigationsToAppBoundDomains' property to WKWebViewConfiguration : [Attachment 396710] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 16 16:43:32 PDT 2020

Andy Estes <aestes at apple.com> has granted Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 210620: Add a new 'limitNavigationsToAppBoundDomains' property to

Attachment 396710: Patch


--- Comment #6 from Andy Estes <aestes at apple.com> ---
Comment on attachment 396710
  --> https://bugs.webkit.org/attachment.cgi?id=396710

View in context: https://bugs.webkit.org/attachment.cgi?id=396710&action=review

>>> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:1256
>>> +	 _limitsNavigationToAppBoundDomains = !ignoresAppBoundDomains;
>> Seems odd that setting one configuration property has the side effect of
changing another one. If these two properties are mutually exclusive, should
have a single enum property instead with possible values of
`ignoresAppBoundDomains` and `limitsToAppBoundDomains`?
> One is internal SPI that is used to gate several things. I just wanted to
make sure that when the SPI was used, this new flag wasn't left in an
inconsistent state.

But this just changes the value reflected by the API, not how it's enforced
(but maybe that's for a follow-up). Anyway, I'd be in favor of not changing a
value set by the API/SPI client but just documenting what the behavior is when
there is a conflict between the two configuration settings.

More information about the webkit-reviews mailing list