[webkit-reviews] review granted: [Bug 175454] Redesign how we do for-of iteration for JSArrays : [Attachment 396692] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 175454: Redesign how we do for-of iteration for JSArrays
https://bugs.webkit.org/show_bug.cgi?id=175454

Attachment 396692: Patch

https://bugs.webkit.org/attachment.cgi?id=396692&action=review




--- Comment #27 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 396692
  --> https://bugs.webkit.org/attachment.cgi?id=396692
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396692&action=review

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:973
> +    FrozenValue* bottomValueMatchingSpeculation(SpeculatedType spec)

I feel like this helper should be in Graph.

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:6750
> +		       flushForTerminal();

You don't need this for branches unless they can go backward.

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:6836
> +		       flushForTerminal();

You don't have to do this unless this is a backward jump.

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:6854
> +		   flushForTerminal();

You don't have to do this unless this is a backward jump.

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:6913
> +		       flushForTerminal();

You don't have to do this unless one of the destinations is backwards.

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:6935
> +		       flushForTerminal();

You don't have to do this unless one of the destinations is backwards.

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:6965
> +		       flushForTerminal();

You don't have to do this unless the destination is backwards.

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:6989
> +		       flushForTerminal();

You don't have to do this unless the destination is backwards.

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:7019
> +		       flushForTerminal();

You don't have to do this unless one of the destinations is backwards.

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:7062
> +		       flushForTerminal();

You don't have to do this unless one of the destinations is backwards.

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:7085
> +		       flushForTerminal();

You don't have to do this unless the destination is backwards.

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:7104
> +		   flushForTerminal();

You don't have to do this unless the destination is backwards.