[webkit-reviews] review granted: [Bug 210605] REGRESSION(r259480): Two new failing i18n tests : [Attachment 396676] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 210605: REGRESSION(r259480): Two new failing i18n tests
https://bugs.webkit.org/show_bug.cgi?id=210605

Attachment 396676: Patch

https://bugs.webkit.org/attachment.cgi?id=396676&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 396676
  --> https://bugs.webkit.org/attachment.cgi?id=396676
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396676&action=review

> Source/JavaScriptCore/runtime/IntlDateTimeFormat.cpp:134
> +    if (canonical.isNull() || canonical == "Etc/UTC"_s || canonical ==
"Etc/GMT"_s)
> +	   canonical = "UTC"_s;

Nicer if we found a way to share code with the below instead of repeating
twice.