[webkit-reviews] review granted: [Bug 209859] [WebXR] Test IDLs and stubs : [Attachment 396646] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 209859: [WebXR] Test IDLs and stubs
https://bugs.webkit.org/show_bug.cgi?id=209859

Attachment 396646: Patch

https://bugs.webkit.org/attachment.cgi?id=396646&action=review




--- Comment #20 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 396646
  --> https://bugs.webkit.org/attachment.cgi?id=396646
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396646&action=review

> Source/WebCore/testing/FakeXRButtonStateInit.idl:26
> +// Bcause the primary button is always guaranteed to be present, and other
buttons

s/Bcause/Because/

> Source/WebCore/testing/WebFakeXRDevice.cpp:36
> +void WebFakeXRDevice::setViews(Vector<FakeXRViewInit>) { }

add some CRLF here and below. in other files as well.

> Source/WebCore/testing/WebFakeXRDevice.h:44
> +void setViews(Vector<FakeXRViewInit>);

Indentation.
Ditto below.

> Source/WebCore/testing/WebXRTest.idl:44
> +  Promise<void> disconnectAllDevices();

two spaces vs four spaces below.

> LayoutTests/imported/w3c/web-platform-tests/webxr/resources/webxr_util.js:21
> +    }

Maybe add a comment this is dedicated to WebKit/WebKit test runner.
Ideally, we should isolate that code in a vendor specific file but since there
is already Chromium specific code...