[webkit-reviews] review granted: [Bug 210594] Validate socket in NetworkRTCProvider::wrapNewTCPConnection : [Attachment 396627] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 210594: Validate socket in NetworkRTCProvider::wrapNewTCPConnection
https://bugs.webkit.org/show_bug.cgi?id=210594

Attachment 396627: Patch

https://bugs.webkit.org/attachment.cgi?id=396627&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 396627
  --> https://bugs.webkit.org/attachment.cgi?id=396627
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396627&action=review

> Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp:176
> +	   if (auto socket =
m_pendingIncomingSockets.take(newConnectionSocketIdentifier))
> +	       addSocket(identifier,
makeUnique<LibWebRTCSocketClient>(identifier, *this, WTFMove(socket),
Socket::Type::ServerConnectionTCP));

Would logging when the socket is NULL be helpful?