[webkit-reviews] review granted: [Bug 210589] REGRESSION (r260102): ASSERTION FAILED: m_arbitrators.contains(proxy) in WebKit::SharedArbitrator::endRoutingArbitrationForArbitrator : [Attachment 396607] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 210589: REGRESSION (r260102): ASSERTION FAILED:
m_arbitrators.contains(proxy) in
WebKit::SharedArbitrator::endRoutingArbitrationForArbitrator
https://bugs.webkit.org/show_bug.cgi?id=210589

Attachment 396607: Patch

https://bugs.webkit.org/attachment.cgi?id=396607&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 396607
  --> https://bugs.webkit.org/attachment.cgi?id=396607
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396607&action=review

> Source/WebCore/platform/audio/mac/AudioSessionMac.mm:104
>	   m_routingArbitrationClient->leaveRoutingAbritration();
> +	   m_private->inRoutingArbitration = false;

Nit: I think it is generally a good idea to change the state before making the
callback in case the callback results in a call back into this module.