[webkit-reviews] review granted: [Bug 210575] REGRESSION (r258337): Crash when right clicking on link that uses the system UI font with optimizeLegibility on Mojave : [Attachment 396583] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 210575: REGRESSION (r258337): Crash when right clicking on link that uses
the system UI font with optimizeLegibility on Mojave
https://bugs.webkit.org/show_bug.cgi?id=210575

Attachment 396583: Patch

https://bugs.webkit.org/attachment.cgi?id=396583&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 396583
  --> https://bugs.webkit.org/attachment.cgi?id=396583
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396583&action=review

> Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm:73
> +	   return [NSFont
fontWithDescriptor:WebKit::fontDescriptorWithFontAttributes(font.fontDescriptor
.fontAttributes) size:0];

Could we share even more code?