[webkit-reviews] review denied: [Bug 210570] ThreadedScrollingTree::scrollingTreeNodeDidScroll() should protect the m_scrollingCoordinator when dispatching its async operation : [Attachment 396570] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 15 14:57:15 PDT 2020


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 210570: ThreadedScrollingTree::scrollingTreeNodeDidScroll() should protect
the m_scrollingCoordinator when dispatching its async operation
https://bugs.webkit.org/show_bug.cgi?id=210570

Attachment 396570: Patch

https://bugs.webkit.org/attachment.cgi?id=396570&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 396570
  --> https://bugs.webkit.org/attachment.cgi?id=396570
Patch

If we've cleared the m_scrollingCoordinator on the ThreadedScrolling tree, I
don't think we need to keep the scrollingCoordinator alive in order to call
scheduleUpdateScrollPositionAfterAsyncScroll. We should just null-check
m_scrollingCoordinator in the block.


More information about the webkit-reviews mailing list