[webkit-reviews] review granted: [Bug 184629] constructObjectFromPropertyDescriptor() is incorrect with partial descriptors : [Attachment 396533] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 184629: constructObjectFromPropertyDescriptor() is incorrect with partial
descriptors
https://bugs.webkit.org/show_bug.cgi?id=184629

Attachment 396533: Patch

https://bugs.webkit.org/attachment.cgi?id=396533&action=review




--- Comment #3 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 396533
  --> https://bugs.webkit.org/attachment.cgi?id=396533
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396533&action=review

> Source/JavaScriptCore/runtime/ObjectConstructor.h:98
> +    JSObject* result = constructEmptyObject(globalObject);

Huh, did this used to be able to throw? Most callsites don't use a ThrowScope
but there's still a good handful of them that do...