[webkit-reviews] review granted: [Bug 210558] REGRESSION (r259762): Should always hit test for editable elements if the WKWebView is fully editable : [Attachment 396553] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 210558: REGRESSION (r259762): Should always hit test for editable elements
if the WKWebView is fully editable
https://bugs.webkit.org/show_bug.cgi?id=210558

Attachment 396553: Patch

https://bugs.webkit.org/attachment.cgi?id=396553&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 396553
  --> https://bugs.webkit.org/attachment.cgi?id=396553
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396553&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:205
> +    NSArray<_WKTextInputContext *> *contexts;

Nit - maybe just move this down so that it’s `NSArray<_WKTextInputContext *>
*contexts = [webView synchronouslyRequestTextInputContextsInRect:[webView
bounds]];`?