[webkit-reviews] review denied: [Bug 207290] [Web Animations] Add support for `pseudoElement` on `KeyframeEffect` and `KeyframeEffectOptions` : [Attachment 396524] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied Antoine Quint <graouts at apple.com>'s
request for review:
Bug 207290: [Web Animations] Add support for `pseudoElement` on
`KeyframeEffect` and `KeyframeEffectOptions`
https://bugs.webkit.org/show_bug.cgi?id=207290

Attachment 396524: Patch

https://bugs.webkit.org/attachment.cgi?id=396524&action=review




--- Comment #12 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 396524
  --> https://bugs.webkit.org/attachment.cgi?id=396524
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396524&action=review

> Source/WebCore/animation/KeyframeEffect.cpp:1139
> +	   bool isLegacy = pseudoElement == ":before" || pseudoElement ==
":after" || pseudoElement == ":first-letter" || pseudoElement == ":first-line";
> +	   auto pseudoType =
CSSSelector::parsePseudoElementType(pseudoElement.substring(isLegacy ? 1 : 2));
> +	   if (pseudoType == CSSSelector::PseudoElementUnknown)

This parses xxbefore as a valid pseudo element.

> Source/WebCore/animation/KeyframeEffect.cpp:1154
> +void KeyframeEffect::invalidateTargetElementOrPseudoElement(Element*
previousTargetElementOrPseudoElement)

Would this be more like didChangeTargetElementOrPseudoElement?