[webkit-reviews] review granted: [Bug 210463] [GTK4] Provide an alternative to gtk_widget_{get, is}_toplevel() : [Attachment 396406] Patch v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 15 06:00:10 PDT 2020
Carlos Garcia Campos <cgarcia at igalia.com> has granted Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 210463: [GTK4] Provide an alternative to gtk_widget_{get,is}_toplevel()
https://bugs.webkit.org/show_bug.cgi?id=210463
Attachment 396406: Patch v2
https://bugs.webkit.org/attachment.cgi?id=396406&action=review
--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 396406
--> https://bugs.webkit.org/attachment.cgi?id=396406
Patch v2
View in context: https://bugs.webkit.org/attachment.cgi?id=396406&action=review
> Source/WebCore/ChangeLog:23
> +2020-04-13 Adrian Perez de Castro <aperez at igalia.com>
Double changelog.
> Source/WebCore/platform/gtk/GtkUtilities.cpp:50
> +
why?
> Source/WebCore/platform/gtk/GtkVersioning.h:25
> +#if GTK_CHECK_VERSION(3, 90, 0)
why not USE(GTK4)? it's clearer.
> Source/WebCore/platform/gtk/GtkVersioning.h:43
> +gtk_window_get_position(GtkWindow*, int* x, int *y)
int* y
> Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp:202
> + // There is no GtkWidget.configure-event in GTK4, move is not
supported.
GtkWidget::configure-event
More information about the webkit-reviews
mailing list