[webkit-reviews] review granted: [Bug 210453] [GTK4] Adapt to cursor API changes : [Attachment 396463] Patch v2

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 210453: [GTK4] Adapt to cursor API changes
https://bugs.webkit.org/show_bug.cgi?id=210453

Attachment 396463: Patch v2

https://bugs.webkit.org/attachment.cgi?id=396463&action=review




--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 396463
  --> https://bugs.webkit.org/attachment.cgi?id=396463
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=396463&action=review

> Source/WebCore/platform/gtk/CursorGtk.cpp:43
> +#if USE(GTK4)
> +static GRefPtr<GdkCursor> fallbackCursor()
> +{
> +    return adoptGRef(gdk_cursor_new_from_name("default", nullptr));
> +}
> +#endif // USE(GTK4)

Would it make sene to cache this? using NeverDestroyed? I guess it will be used
a lot. I'm not sure how expensive it is, or whether it's already cached by GTK
though.