[webkit-reviews] review granted: [Bug 210529] Video elements don't return to the correct position when exiting fullscreen : [Attachment 396491] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Peng Liu <peng.liu6 at apple.com>'s
request for review:
Bug 210529: Video elements don't return to the correct position when exiting
fullscreen
https://bugs.webkit.org/show_bug.cgi?id=210529

Attachment 396491: Patch

https://bugs.webkit.org/attachment.cgi?id=396491&action=review




--- Comment #3 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 396491
  --> https://bugs.webkit.org/attachment.cgi?id=396491
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396491&action=review

> Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:780
>	       page->setSuppressVisibilityUpdates(false);
> +	       page->setNeedsDOMWindowResizeEvent();

Aha! I bet the previous call to `setSuppressVisibilityUpdate(true)` has the
unintended side effect of suppressing the "resize" event too! This seems like a
fine fix.