[webkit-reviews] review granted: [Bug 199117] REGRESSION: [ Mojave+ Debug WK1 ] Layout Test imported/blink/storage/indexeddb/blob-basics-metadata.html is a flaky timeout : [Attachment 396455] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 14 17:26:01 PDT 2020


Alexey Proskuryakov <ap at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 199117: REGRESSION: [ Mojave+ Debug WK1 ] Layout Test
imported/blink/storage/indexeddb/blob-basics-metadata.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=199117

Attachment 396455: Patch

https://bugs.webkit.org/attachment.cgi?id=396455&action=review




--- Comment #23 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 396455
  --> https://bugs.webkit.org/attachment.cgi?id=396455
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396455&action=review

Seems like there is agreement about that, marking r+.

> Tools/Scripts/run-javascriptcore-tests:526
> +if (isAppleMacWebKit() || isEmbeddedWebKit()) {

Does this work for embedded, and is it necessary?

> Tools/Scripts/webkitpy/port/driver.py:444
> +
> +

Two newlines?


More information about the webkit-reviews mailing list