[webkit-reviews] review granted: [Bug 210519] Use CFArrayGetValues() in createArchiveList() in WebCoreArgumentCodersMac.mm : [Attachment 396472] Patch v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 210519: Use CFArrayGetValues() in createArchiveList() in
WebCoreArgumentCodersMac.mm
https://bugs.webkit.org/show_bug.cgi?id=210519

Attachment 396472: Patch v1

https://bugs.webkit.org/attachment.cgi?id=396472&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 396472
  --> https://bugs.webkit.org/attachment.cgi?id=396472
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=396472&action=review

> Source/WebKit/Shared/mac/WebCoreArgumentCodersMac.mm:127
> +    for (size_t i = 0; i < static_cast<size_t>(*objectCount); ++i) {

This line should not have been changed. There’s no reason to cast this just so
we can use a different type for the loop. CFIndex is fine.