[webkit-reviews] review granted: [Bug 210511] Web Inspector: Console: treat long strings as non-simple so they aren't truncated : [Attachment 396450] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 210511: Web Inspector: Console: treat long strings as non-simple so they
aren't truncated
https://bugs.webkit.org/show_bug.cgi?id=210511

Attachment 396450: Patch

https://bugs.webkit.org/attachment.cgi?id=396450&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 396450
  --> https://bugs.webkit.org/attachment.cgi?id=396450
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396450&action=review

So how does this look when you log a long string?

> Source/WebInspectorUI/UserInterface/Views/FormattedValue.js:30
> +WI.FormattedValue.isSimpleString = function(string)

Nice! Could be tested.