[webkit-reviews] review denied: [Bug 210504] Add bundle SPI to call WebPage::setTopContentInset : [Attachment 396442] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 14 11:50:14 PDT 2020


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 210504: Add bundle SPI to call WebPage::setTopContentInset
https://bugs.webkit.org/show_bug.cgi?id=210504

Attachment 396442: Patch

https://bugs.webkit.org/attachment.cgi?id=396442&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 396442
  --> https://bugs.webkit.org/attachment.cgi?id=396442
Patch

Please explain how this interacts with
WebViewImpl::updateContentInsetsIfAutomatic() -
m_automaticallyAdjustsContentInsets is on by default in WKWebView. That's
called from WebViewImpl::renewGStateI(), which is called whenever AppKit
jiggles the view hierarchy, which is a lot.


More information about the webkit-reviews mailing list