[webkit-reviews] review granted: [Bug 210501] [iPadOS] Wikipedia articles lay out incorrectly in 1/3 multitasking window : [Attachment 396439] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 14 11:19:58 PDT 2020
Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 210501: [iPadOS] Wikipedia articles lay out incorrectly in 1/3 multitasking
window
https://bugs.webkit.org/show_bug.cgi?id=210501
Attachment 396439: Patch
https://bugs.webkit.org/attachment.cgi?id=396439&action=review
--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 396439
--> https://bugs.webkit.org/attachment.cgi?id=396439
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=396439&action=review
> Source/WebCore/page/Quirks.cpp:760
> + return equalLettersIgnoringASCIICase(m_document->url().host(),
"en.wikipedia.org");
You're missing like 160 subdomains
> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:3892
> + return 504;
Is rounding down to 500 an actual problem? Does it only make me feel better?
More information about the webkit-reviews
mailing list