[webkit-reviews] review requested: [Bug 205876] Move allowPlugins to FrameLoader : [Attachment 396300] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rbuis at igalia.com> has asked  for review:
Bug 205876: Move allowPlugins to FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=205876

Attachment 396300: Patch

https://bugs.webkit.org/attachment.cgi?id=396300&action=review




--- Comment #12 from Rob Buis <rbuis at igalia.com> ---
Comment on attachment 396300
  --> https://bugs.webkit.org/attachment.cgi?id=396300
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396300&action=review

>> Source/WebCore/loader/SubframeLoader.cpp:157
>> +	if ((!m_frame.settings().arePluginsEnabled() &&
!MIMETypeRegistry::isApplicationPluginMIMEType(mimeType)))
> 
> Is this good? If we are wiling to do the check directly then why do we need
an allowPlugins function at all?

It did look stange to me so I simply replaced && with || and that broke a lot
of stuff. So it seems that arePluginsEnabled is enough to stop requesting the
plugin, *unless* we deal with an application plugin. I chose a different logic
form to hopefully make it more clear.