[webkit-reviews] review requested: [Bug 210493] Remove downloadAttribute from DocumentLoader : [Attachment 396411] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rbuis at igalia.com> has asked  for review:
Bug 210493: Remove downloadAttribute from DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=210493

Attachment 396411: Patch

https://bugs.webkit.org/attachment.cgi?id=396411&action=review




--- Comment #2 from Rob Buis <rbuis at igalia.com> ---
Comment on attachment 396411
  --> https://bugs.webkit.org/attachment.cgi?id=396411
Patch

Alex, in https://bugs.webkit.org/show_bug.cgi?id=196755 you passed in
loadPostRequest the frameLoadRequest download attribute into the
NavigationAction but passed { } to store that for download attribute into the
DocumentLoader. Was that intentional? This removal patch can only work in case
both values are the same or in case the value does not matter for POST.
Also are there tests or should this be manually checked?