[webkit-reviews] review granted: [Bug 210460] Add ENABLE_CUSTOM_SCROLLBARS and define it for macOS and for non-Cocoa platforms : [Attachment 396374] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 210460: Add ENABLE_CUSTOM_SCROLLBARS and define it for macOS and for
non-Cocoa platforms
https://bugs.webkit.org/show_bug.cgi?id=210460

Attachment 396374: Patch

https://bugs.webkit.org/attachment.cgi?id=396374&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 396374
  --> https://bugs.webkit.org/attachment.cgi?id=396374
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396374&action=review

> Source/WTF/wtf/PlatformEnable.h:840
> -#if !defined(ENABLE_CUSTOM_SCROLLBARS)
> +#if !defined(ENABLE_CUSTOM_SCROLLBARS) && !PLATFORM(COCOA)
>  #define ENABLE_CUSTOM_SCROLLBARS 1
>  #endif

This should be fixed in PlatformEnableCocoa.h instead, like this:

#if !defined(ENABLE_CUSTOM_SCROLLBARS) && !PLATFORM(MAC)
#define ENABLE_CUSTOM_SCROLLBARS 0
#endif

PlatformEnableCocoa.h doesn't ever have to set it to 1.