[webkit-reviews] review denied: [Bug 210344] http/tests/in-app-browser-privacy/app-bound-domain.html is a constant failure on iOS : [Attachment 396101] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied
katherine_cheney at apple.com's request for review:
Bug 210344: http/tests/in-app-browser-privacy/app-bound-domain.html is a
constant failure on iOS
https://bugs.webkit.org/show_bug.cgi?id=210344

Attachment 396101: Patch

https://bugs.webkit.org/attachment.cgi?id=396101&action=review




--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 396101
  --> https://bugs.webkit.org/attachment.cgi?id=396101
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396101&action=review

> Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:131
> +	   [[NSUserDefaults standardUserDefaults] setBool:NO
forKey:@"WebKitDebugIsInAppBrowserPrivacyEnabled"];

Two thoughts:
1. TestController::platformAddTestOptions is a place where we are supposed to
be writing to options, and this reads from options.  I think
TestController::platformResetPreferencesToConsistentValues or
TestController::platformResetStateToConsistentValues  and maybe
TestController::updatePlatformSpecificTestOptionsForTest would be a better
place to reset and set these values in NSUserDefaults.
2. Instead of setting the bool to NO, let's remove object for key.