[webkit-reviews] review granted: [Bug 210419] [CSS Selectors] Selectors Level 4 specificity calculation for pseudo classes : [Attachment 396268] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 210419: [CSS Selectors] Selectors Level 4 specificity calculation for
pseudo classes
https://bugs.webkit.org/show_bug.cgi?id=210419

Attachment 396268: patch

https://bugs.webkit.org/attachment.cgi?id=396268&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 396268
  --> https://bugs.webkit.org/attachment.cgi?id=396268
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396268&action=review

> LayoutTests/fast/css/is-specificity-3-expected.html:6
> +<div style="color: purple; background-color: blue;">Text</nottarget>

Mixing div and nottarget tags?

> LayoutTests/fast/css/matches-specificity-3-expected.html:6
> +<div style="color: purple; background-color: blue;">Text</nottarget>

Ditto.

> Source/WebCore/css/CSSSelector.cpp:95
> +static unsigned selectorSpecificity(const CSSSelector& firstSimpleSelector)

Would be nice to have a typedef for "specificity" rather than using 'unsigned'
everywhere.