[webkit-reviews] review granted: [Bug 210335] Add a timer to AVVideoCaptureSource to verify reception of frames : [Attachment 396197] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 13 09:38:20 PDT 2020
Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 210335: Add a timer to AVVideoCaptureSource to verify reception of frames
https://bugs.webkit.org/show_bug.cgi?id=210335
Attachment 396197: Patch
https://bugs.webkit.org/attachment.cgi?id=396197&action=review
--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 396197
--> https://bugs.webkit.org/attachment.cgi?id=396197
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=396197&action=review
> Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h:143
> + static constexpr Seconds verifyCaptureInterval = 3_s;
Is three seconds long enough?
> Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h:144
> + static const uint64_t framesToDropWhenStarting = 4;
Shouldn't this be relative to the capture rate?
> Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:163
> + RELEASE_LOG_ERROR(WebRTC, "AVVideoCaptureSource::verifyIsCapturing - no
frame received in %d seconds, failing",
static_cast<int>(m_verifyCapturingTimer.repeatInterval().value()));
> + captureFailed();
Failing capture completely is quite severe. Should we try to stop and restart
the camera one time?
More information about the webkit-reviews
mailing list