[webkit-reviews] review granted: [Bug 210353] Null ptr Deref in RadioButtonGroups::updateCheckedState : [Attachment 396125] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Pinki Gyanchandani
<pgyanchandani at apple.com>'s request for review:
Bug 210353: Null ptr Deref in RadioButtonGroups::updateCheckedState
https://bugs.webkit.org/show_bug.cgi?id=210353

Attachment 396125: Patch

https://bugs.webkit.org/attachment.cgi?id=396125&action=review




--- Comment #8 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 396125
  --> https://bugs.webkit.org/attachment.cgi?id=396125
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396125&action=review

> Source/WebCore/ChangeLog:8
> +	   This crash happend when the default checked setter was called for an
input element and RadioButtonGroup was NULL.

typo: happend

> Source/WebCore/ChangeLog:9
> +	   Added condition to deference the group only if it is valid.

typo: deference -> dereference
s/valid/non-null

> LayoutTests/fast/forms/input-element-default-checked-setter-crash.html:4
> +<p>This test passes if there is no crash</p>

nit: There should be a period at the end of your sentence.