[webkit-reviews] review granted: [Bug 210336] check-webkit-style should warn about 'decode' functions with missing WARN_UNUSED_RETURN attribute : [Attachment 396088] Patch v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 210336: check-webkit-style should warn about 'decode' functions with
missing WARN_UNUSED_RETURN attribute
https://bugs.webkit.org/show_bug.cgi?id=210336

Attachment 396088: Patch v1

https://bugs.webkit.org/attachment.cgi?id=396088&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 396088
  --> https://bugs.webkit.org/attachment.cgi?id=396088
Patch v1

For functions returning bool I think this is a good rule. For ones returning
Optional I think this is not helpful, but I suppose no big deal to comply
anyway.