[webkit-reviews] review granted: [Bug 210297] First render after a process swap does not use accelerated rendering : [Attachment 396010] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 210297: First render after a process swap does not use accelerated
rendering
https://bugs.webkit.org/show_bug.cgi?id=210297

Attachment 396010: Patch

https://bugs.webkit.org/attachment.cgi?id=396010&action=review




--- Comment #10 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 396010
  --> https://bugs.webkit.org/attachment.cgi?id=396010
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396010&action=review

Good idea!

> Source/WebKit/ChangeLog:26
> +	   2. In the UIProcess, when we get the
DrawingAreaProxy::EnterAcceleratedCompositingMode
> +	      IPC and we already have a root layer, we add the new one behind
the existing one
> +	      instead of replacing the existing one. As a result, the new layer
will get
> +	      accelerated compositing but will not be visible on screen yet.

I wonder if there are cases with transparent layers or missing tiles where this
could lead to both pages being partially visible at the same time.

Maybe a stronger hiding strategy is needed?