[webkit-reviews] review granted: [Bug 210291] Add null pointer checkings in WebFullScreenManager : [Attachment 395977] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Peng Liu <peng.liu6 at apple.com>'s
request for review:
Bug 210291: Add null pointer checkings in WebFullScreenManager
https://bugs.webkit.org/show_bug.cgi?id=210291

Attachment 395977: Patch

https://bugs.webkit.org/attachment.cgi?id=395977&action=review




--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 395977
  --> https://bugs.webkit.org/attachment.cgi?id=395977
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395977&action=review

Patch looks good. A better patch would explain why this is being done in the
change log description.

> Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:54
> +    if (!element)

Ok as is. No change needed. Is the purpose of this change to workaround an
unreproducible bug? Is so then the the optimal solution would include a FIXME
comment explaining this/referencing the bug for the root cause fix. If not,
then The optimal solution is to remove the assert.

Same comment for all changes below.