[webkit-reviews] review granted: [Bug 210217] [LLInt] Add fast path for TypedArray access on LLInt 32-bits : [Attachment 395892] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Caio Lima
<ticaiolima at gmail.com>'s request for review:
Bug 210217: [LLInt] Add fast path for TypedArray access on LLInt 32-bits
https://bugs.webkit.org/show_bug.cgi?id=210217

Attachment 395892: Patch

https://bugs.webkit.org/attachment.cgi?id=395892&action=review




--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 395892
  --> https://bugs.webkit.org/attachment.cgi?id=395892
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395892&action=review

r=me

> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1565
> +    getByValTypedArray(t0, t1, finishIntGetByVal, finishDoubleGetByVal,
.opGetByValSlow, cagedPrimitive)

You should define `cagedPrimitive` in 32bit LowLevelInterpreter as empty macro
instead of passing it to getByValTypedArray