[webkit-reviews] review granted: [Bug 210278] [ macOS debug wk2 ] REGRESSION(r259762): ASSERTION FAILED: !needsLayout() on fast/events/scroll-subframe-in-rendering-update.html : [Attachment 395962] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 210278: [ macOS debug wk2 ] REGRESSION(r259762): ASSERTION FAILED:
!needsLayout() on fast/events/scroll-subframe-in-rendering-update.html
https://bugs.webkit.org/show_bug.cgi?id=210278

Attachment 395962: Patch

https://bugs.webkit.org/attachment.cgi?id=395962&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 395962
  --> https://bugs.webkit.org/attachment.cgi?id=395962
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395962&action=review

> Source/WebCore/ChangeLog:10
> +	   Only EventRegion paint the contents of the widget if the widget is a
frame view that
> +	   does not need layout.

This says what the patch does. But where’s the explanation of why?

Might even want the reason why as a comment in the source code.

Not arguing for something super-wordy, but the relevant question for comments
is always "why".