[webkit-reviews] review granted: [Bug 210267] ProxyObject::defineOwnProperty() should conditionally throw on falsy trap result : [Attachment 395956] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 210267: ProxyObject::defineOwnProperty() should conditionally throw on
falsy trap result
https://bugs.webkit.org/show_bug.cgi?id=210267

Attachment 395956: Patch

https://bugs.webkit.org/attachment.cgi?id=395956&action=review




--- Comment #4 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 395956
  --> https://bugs.webkit.org/attachment.cgi?id=395956
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395956&action=review

r=me with comment

> Source/JavaScriptCore/ChangeLog:12
> +	   Also replaces 2 recently added throwTypeError() calls with
throwVMTypeError(),
> +	   as the latter seems to be preferred in ProxyObject.

Seems like we should go the other way if we're not using the result, since
throwVMTypeError just encodes the JSValue.