[webkit-reviews] review granted: [Bug 210253] Web Inspector: Debugger: debug hooks should also be emitted for the first sub-expression in a comma expression : [Attachment 395920] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 210253: Web Inspector: Debugger: debug hooks should also be emitted for the
first sub-expression in a comma expression
https://bugs.webkit.org/show_bug.cgi?id=210253

Attachment 395920: Patch

https://bugs.webkit.org/attachment.cgi?id=395920&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 395920
  --> https://bugs.webkit.org/attachment.cgi?id=395920
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395920&action=review

r=me

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:3539
>      if (!shouldEmitDebugHooks())
>	   return;

Maybe we could use LIKELY macros here.