[webkit-reviews] review granted: [Bug 210225] Add curly braces after one line if statement for the case when we aren't using the internal SDK : [Attachment 395887] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted
katherine_cheney at apple.com's request for review:
Bug 210225: Add curly braces after one line if statement for the case when we
aren't using the internal SDK
https://bugs.webkit.org/show_bug.cgi?id=210225

Attachment 395887: Patch

https://bugs.webkit.org/attachment.cgi?id=395887&action=review




--- Comment #3 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 395887
  --> https://bugs.webkit.org/attachment.cgi?id=395887
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395887&action=review

r=me to fix tests, even though this is technically a style violation.

> Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:430
>		   WEBSITE_DATA_STORE_ADDITIONS

Eventually, the `WEBSITE_DATA_STORE_ADDITIONS` macro should probably have a do
{ ... } while(0) loop around its contents if it's multi-line, and maybe defined
to `(void)0` if it is not set (in this file.  Then the curly braces can be
removed.