[webkit-reviews] review granted: [Bug 210224] Handle [PDFDocument initWithProvider:] returning nil : [Attachment 395880] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 210224: Handle [PDFDocument initWithProvider:] returning nil
https://bugs.webkit.org/show_bug.cgi?id=210224

Attachment 395880: Patch

https://bugs.webkit.org/attachment.cgi?id=395880&action=review




--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 395880
  --> https://bugs.webkit.org/attachment.cgi?id=395880
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395880&action=review

r=me

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:873
> +    if (!m_incrementalPDFLoadingEnabled || !m_backgroundThreadDocument) {
>	   m_backgroundThreadDocument = nil;

You could just do a separate early return, since it's kinda silly to say "if
m_backgroundThreadDocument is null, set m_backgroundThreadDocument to null".