[webkit-reviews] review granted: [Bug 210095] [Async overflow scroll] Horizontal scrolls can trigger unwanted back swipes : [Attachment 395872] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 210095: [Async overflow scroll] Horizontal scrolls can trigger unwanted
back swipes
https://bugs.webkit.org/show_bug.cgi?id=210095

Attachment 395872: Patch

https://bugs.webkit.org/attachment.cgi?id=395872&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 395872
  --> https://bugs.webkit.org/attachment.cgi?id=395872
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395872&action=review

> Source/WebCore/platform/cocoa/ScrollController.mm:107
> +	   // FIXME: Trying to decide if a gesture is horizontal or vertical at
the "began" phase is very error-prone.

This likely wants something more like a generalized VGC::PendingSwipeTracker