[webkit-reviews] review granted: [Bug 209998] Web Inspector: Debugger: treat comma sub-expressions as separate statements : [Attachment 395537] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 209998: Web Inspector: Debugger: treat comma sub-expressions as separate
statements
https://bugs.webkit.org/show_bug.cgi?id=209998

Attachment 395537: Patch

https://bugs.webkit.org/attachment.cgi?id=395537&action=review




--- Comment #9 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 395537
  --> https://bugs.webkit.org/attachment.cgi?id=395537
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395537&action=review

Awesome! r=me

> Source/JavaScriptCore/parser/Parser.cpp:901
> +		       head = tail = context.createCommaExpr(headLocation,
head);

Clever. Maybe too clever.

>
LayoutTests/inspector/formatting/resources/javascript-tests/for-statements.js:3
8
>  for(var x=1;x<len;++x)1;
> -for(var x=1,len=10;x<len;++x)1;
> +for(var x=1,len=1;len=10,x<len;len=5,++x)1;

FWIW, if you're purely additive to these tests, the diffs end up easier to read
and we hypothetically test more cases.