[webkit-reviews] review granted: [Bug 210208] Fix handling non-linearized PDFs when incremental PDF loading is enabled : [Attachment 395852] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 210208: Fix handling non-linearized PDFs when incremental PDF loading is
enabled
https://bugs.webkit.org/show_bug.cgi?id=210208

Attachment 395852: Patch

https://bugs.webkit.org/attachment.cgi?id=395852&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 395852
  --> https://bugs.webkit.org/attachment.cgi?id=395852
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395852&action=review

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:142
> +static const int32_t maximumRangeRequestPosition =
std::numeric_limits<int32_t>::max();

INT32_MAX is a reasonable maximum? Seems ... big.