[webkit-reviews] review granted: [Bug 210174] [JSC] Threading JSGlobalObject in RegExp::match properly : [Attachment 395773] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 210174: [JSC] Threading JSGlobalObject in RegExp::match properly
https://bugs.webkit.org/show_bug.cgi?id=210174

Attachment 395773: Patch

https://bugs.webkit.org/attachment.cgi?id=395773&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 395773
  --> https://bugs.webkit.org/attachment.cgi?id=395773
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395773&action=review

> Source/JavaScriptCore/runtime/RegExpInlines.h:113
> +	   if (nullOrGlobalObject) {

This is the downside of us using JSCell* everywhere instead of JSCell&

When the pointer is actually nullable, we need to name the variable properly